Open
Conversation
rchl
force-pushed
the
feat/enumeration-base-type
branch
from
7aa44a7 to
a057c2f
Compare
rchl
force-pushed
the
feat/enumeration-base-type
branch
from
a057c2f to
dd01d9c
Compare
rchl
commented
Apr 20, 2026
| @since 3.17.0 support for relative patterns. | ||
| """ | ||
| kind: NotRequired['WatchKind'] | ||
| kind: NotRequired[Union[Uint, WatchKind]] |
Member
Author
There was a problem hiding this comment.
This is potentially controversial or even wrong. Since we use IntFlag for this one, we don't really need to allow int value for it.
Though from the spec perspective it is probably correct because the value is a bitwise flag so not necessarily the exact value that matches one of the enums.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enumerations that specify
supportsCustomValuesnow get the base type (str or int) included where those are referenced.It solves the use case that #37 was solving but in a different way.
Note that
root_symbol_namewas unused.