Skip to content

chore: potential fix for code quality finding#13802

Open
splincode wants to merge 1 commit intomainfrom
ai-findings-autofix/projects-addon-table-components-table-tr-tr.template.html
Open

chore: potential fix for code quality finding#13802
splincode wants to merge 1 commit intomainfrom
ai-findings-autofix/projects-addon-table-components-table-tr-tr.template.html

Conversation

@splincode
Copy link
Copy Markdown
Member

@splincode splincode commented Apr 8, 2026

The template reference 'plain' is defined inside the @for loop, making it unavailable for the first iteration and potentially causing runtime errors. Move the ng-template definition outside the @for loop to ensure it's accessible for all iterations.

…mplate.html from Copilot Autofix

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Tests completed successfully ✅

Good job 🔥

@splincode splincode changed the title Potential fix for 1 code quality finding chore: potential fix for code quality finding Apr 8, 2026
@splincode splincode marked this pull request as ready for review April 8, 2026 18:55
@splincode splincode requested a review from a team as a code owner April 8, 2026 18:55
@splincode splincode requested review from MarsiBarsi, mdlufy, nsbarsukov, sayranovv, vladimirpotekhin and waterplea and removed request for a team April 8, 2026 18:55
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.79%. Comparing base (7b17838) to head (7f0f421).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13802   +/-   ##
=======================================
  Coverage   60.79%   60.79%           
=======================================
  Files         983      983           
  Lines       12732    12732           
  Branches     1963     1988   +25     
=======================================
  Hits         7740     7740           
+ Misses       4785     4709   -76     
- Partials      207      283   +76     
Flag Coverage Δ
summary 60.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bundlemon
Copy link
Copy Markdown

bundlemon bot commented Apr 8, 2026

BundleMon

Unchanged files (2)
Status Path Size Limits
demo/browser/styles-(hash).css
19.72KB +10%
demo/browser/main-(hash).js
994B +10%

Total files change +1B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*.js
3.07MB (+98B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Visit the preview URL for this PR (updated for commit 7f0f421):

https://taiga-previews-demo--pr13802-ai-findings-autofix-proje-zbu19krb.web.app

(expires Thu, 09 Apr 2026 18:57:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Playwright test results

passed  1421 passed
flaky  3 flaky
skipped  58 skipped

Details

report  Open report ↗︎
stats  1482 tests across 85 suites
duration  48 minutes, 51 seconds
commit  7f0f421

Flaky tests

chromium › tests/addon-charts/pie-chart/pie-chart.pw.spec.ts › PieChart › should be show hints on charts
chromium › tests/kit/input-phone/input-phone.pw.spec.ts › InputPhone › iphone-x › mask="+7 (###) ###-##-##" › New typed character is equal to the previous (already existing) fixed character › +7 | => Type 7 => +7 (7
chromium › tests/kit/input-slider/input-slider.pw.spec.ts › InputSlider › textfield => slider synchronization › pressing ArrowUp/ArrowDown change textfield value and slider position

Skipped tests

chromium › tests/addon-doc/navigation.pw.spec.ts › Navigation › anchor links navigation works › scroll to "tui-doc-example"
chromium › tests/core/dropdown/dropdown.pw.spec.ts › Dropdown › Esc -> Hosted Dropdown
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputCard › update on change
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputCard › update on blur
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputCard › update on submit
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputCardGroup › update on change
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputCardGroup › update on blur
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputCardGroup › update on submit
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputChip › update on change
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputChip › update on blur
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputChip › update on submit
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputColor › update on change
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputColor › update on blur
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputColor › update on submit
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputDate › update on change
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputDate › update on blur
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputDate › update on submit
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputDateMulti › update on change
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputDateMulti › update on blur
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputDateMulti › update on submit
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputDateRange › update on change
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputDateRange › update on blur
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputDateRange › update on submit
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputDateTime › update on change
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputDateTime › update on blur
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputDateTime › update on submit
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputInline › update on change
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputInline › update on blur
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputInline › update on submit
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputMonth › update on change
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputMonth › update on blur
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputMonth › update on submit
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputNumber › update on change
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputNumber › update on blur
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputNumber › update on submit
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputPhone › update on change
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputPhone › update on blur
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputPhone › update on submit
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputPhoneInternational › update on change
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputPhoneInternational › update on blur
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputPhoneInternational › update on submit
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputPin › update on change
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputPin › update on blur
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputPin › update on submit
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputTime › update on change
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputTime › update on blur
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputTime › update on submit
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputYear › update on change
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputYear › update on blur
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputYear › update on submit
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputFiles › update on change
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputFiles › update on blur
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputFiles › update on submit
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › Input › update on change
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › Input › update on blur
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › Input › update on submit
chromium › tests/kit/input-date-range/input-date-range.pw.spec.ts › InputDateRange › items › Press backspace to remove item, textfield is empty
chromium › tests/kit/input-date-time/input-date-time.pw.spec.ts › InputDateTime › API page › should time to pre-fill with zeros on blur

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants