feat(database): add option to get underlying query for property relation#2102
Merged
brendt merged 32 commits intotempestphp:3.xfrom Apr 22, 2026
Merged
Conversation
Benchmark ResultsComparison of Open to see the benchmark results
Generated by phpbench against commit 47da414 |
debbc8f to
ceec41c
Compare
brendt
requested changes
Apr 9, 2026
b234fd9 to
71ee424
Compare
Contributor
Author
|
@brendt had to add If you want i can move that commit into separate pr 71ee424 |
Member
|
No it's fine to keep it here. I'll review later today :) |
…cit attr, unsaved model, nonexistent property, empty result)
…getHasManyThrough/getBelongsToMany calls
…ead of manual property check
…e, return QueryBuilder for select/update/delete support
…s all relation types
…longsToMany query()
…pe for subquery relations
…r BelongsToMany delete support
…e query() for relations
… a public instance method
… instead of duplicating pivot logic
…WasNotInitialized and PropertyWasNotARelation
…t 1G memory limit
71ee424 to
80bc564
Compare
brendt
approved these changes
Apr 22, 2026
Member
|
Awesome :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr to add option to have similar behavior to laravels author->books() to get underlying query for property relation we can chain into
works with all relation types:
now, I wasnt sure about naming it but opted in for
querysince it returns querybuilder same as query() helper just scoped to model property