Update bootstrapping s3 resources for aws provider v4#36
Closed
mtonxbjss wants to merge 1 commit intotfutils:masterfrom
Closed
Update bootstrapping s3 resources for aws provider v4#36mtonxbjss wants to merge 1 commit intotfutils:masterfrom
mtonxbjss wants to merge 1 commit intotfutils:masterfrom
Conversation
Collaborator
|
Closing - this was addressed in v2.0.0, which completely rewrote the bootstrap to use AWS Provider v4+ separate S3 bucket property resources (aws_s3_bucket_versioning, aws_s3_bucket_server_side_encryption_configuration, etc.) instead of the monolithic bucket resource. Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS Provider v4.x splits out a number of S3 bucket configuration blocks into independent S3 resources.
The legacy configuration prevents bootstrapping of a new tfscaffold project on the current version of the AWS provider.
This PR creates the new S3 resources and removes the legacy config blocks from the S3 bucket resource.