Moves setting the app attribute to the _set_cache method#117
Open
vicentealencar wants to merge 1 commit intothadeusb:masterfrom
Open
Moves setting the app attribute to the _set_cache method#117vicentealencar wants to merge 1 commit intothadeusb:masterfrom
vicentealencar wants to merge 1 commit intothadeusb:masterfrom
Conversation
Initializing a Cache instance with a None app and setting it later via init_app causes the app attribute never to be set. This is fine for most cases, since the cache is being set to the app extension. However, it causes crashes when calling the Cache outside of a Flask context (e.g.: spawned threads).
|
Hi there, I've merged this in my fork of the repository at https://github.com/SkierPGP/flask-cache |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initializing a Cache instance with a None app and setting it later
via init_app causes the app attribute never to be set. This is fine for
most cases, since the cache is being set to the app extension. However,
it causes crashes when calling the Cache outside of a Flask context
(e.g.: spawned threads).
I found this while updating a project I was working on from an old Flask-Cache version to the most up-to-date. Our app was crashing when it spawned gevent threads in order to load data in parallel.