Skip to content

fix(test): add teat_autoware module (imu_driver and vehicle_velocity_converter)#681

Open
nokosaaan wants to merge 43 commits intomainfrom
imu-vehicle
Open

fix(test): add teat_autoware module (imu_driver and vehicle_velocity_converter)#681
nokosaaan wants to merge 43 commits intomainfrom
imu-vehicle

Conversation

@nokosaaan
Copy link
Copy Markdown
Contributor

@nokosaaan nokosaaan commented Apr 20, 2026

Description

I have added the imu_driver and vehicle_velocity_converter modules. While I based the test code on the implementation in Autoware, there was no test code for imu_driver, so I created test cases focused on input and output. All test cases have been verified.

Related links

https://github.com/autowarefoundation/autoware_core/tree/main/sensing/autoware_vehicle_velocity_converter/test
https://github.com/tier4/tamagawa_imu_driver/tree/ros2

How was this PR tested?

cargo test --manifest-path /path/to/module/Cargo.toml
test_imu_driver.log
test_vehicle_velocity_converter.log

Notes for reviewers

Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
…verter

Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
…rgo fmt 1

Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
@nokosaaan nokosaaan marked this pull request as ready for review April 20, 2026 10:23
@nokosaaan nokosaaan requested a review from Copilot April 20, 2026 10:23
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new applications/tests/test_autoware module with two subcrates (imu_driver and vehicle_velocity_converter) that model/convert Autoware-like messages and include unit tests for parsing and conversion behavior.

Changes:

  • Introduce imu_driver crate with a Tamagawa IMU binary parser + request builders and unit tests.
  • Introduce vehicle_velocity_converter crate that converts VelocityReport into TwistWithCovarianceStamped + unit tests.
  • Add a top-level test_autoware crate wiring in the new subcrates as path dependencies.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
applications/tests/test_autoware/vehicle_velocity_converter/src/lib.rs Adds message structs + velocity conversion logic and unit tests.
applications/tests/test_autoware/vehicle_velocity_converter/Cargo.toml New crate manifest for vehicle_velocity_converter.
applications/tests/test_autoware/imu_driver/src/lib.rs Adds IMU message structs, Tamagawa binary parsing/generation utilities, and unit tests.
applications/tests/test_autoware/imu_driver/Cargo.toml New crate manifest for imu_driver.
applications/tests/test_autoware/Cargo.toml New top-level test_autoware crate manifest depending on the two subcrates.
applications/tests/test_autoware/src/lib.rs New (currently empty) top-level library file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread applications/tests/test_autoware/imu_driver/src/lib.rs Outdated
Comment thread applications/tests/test_autoware/imu_driver/src/lib.rs Outdated
Comment thread applications/tests/test_autoware/vehicle_velocity_converter/src/lib.rs Outdated
Comment thread applications/tests/test_autoware/Cargo.toml Outdated
Comment thread applications/tests/test_autoware/src/lib.rs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
nokosaaan and others added 3 commits April 20, 2026 19:39
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/tier4/awkernel/sessions/2a6ef5c8-5491-440d-bebf-6968b2fa5827

Co-authored-by: nokosaaan <106376734+nokosaaan@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 20, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/tier4/awkernel_sync/commits/HEAD
    • Triggering command: /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/bin/cargo /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/bin/cargo test --manifest-path applications/tests/test_autoware/imu_driver/Cargo.toml (http block)
  • https://api.github.com/repos/ytakano/acpi/commits/HEAD
    • Triggering command: /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/bin/cargo /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/bin/cargo test --manifest-path applications/tests/test_autoware/imu_driver/Cargo.toml (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
@nokosaaan nokosaaan changed the title feat(test): add teat_autoware module (imu_driver and vehicle_velocity_converter) fix(test): add teat_autoware module (imu_driver and vehicle_velocity_converter) Apr 20, 2026
@nokosaaan nokosaaan requested a review from kobayu858 April 20, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants