fix(test): add teat_autoware module (imu_driver and vehicle_velocity_converter)#681
Open
fix(test): add teat_autoware module (imu_driver and vehicle_velocity_converter)#681
Conversation
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
…verter Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
…rgo fmt 1 Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
There was a problem hiding this comment.
Pull request overview
Adds a new applications/tests/test_autoware module with two subcrates (imu_driver and vehicle_velocity_converter) that model/convert Autoware-like messages and include unit tests for parsing and conversion behavior.
Changes:
- Introduce
imu_drivercrate with a Tamagawa IMU binary parser + request builders and unit tests. - Introduce
vehicle_velocity_convertercrate that convertsVelocityReportintoTwistWithCovarianceStamped+ unit tests. - Add a top-level
test_autowarecrate wiring in the new subcrates as path dependencies.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| applications/tests/test_autoware/vehicle_velocity_converter/src/lib.rs | Adds message structs + velocity conversion logic and unit tests. |
| applications/tests/test_autoware/vehicle_velocity_converter/Cargo.toml | New crate manifest for vehicle_velocity_converter. |
| applications/tests/test_autoware/imu_driver/src/lib.rs | Adds IMU message structs, Tamagawa binary parsing/generation utilities, and unit tests. |
| applications/tests/test_autoware/imu_driver/Cargo.toml | New crate manifest for imu_driver. |
| applications/tests/test_autoware/Cargo.toml | New top-level test_autoware crate manifest depending on the two subcrates. |
| applications/tests/test_autoware/src/lib.rs | New (currently empty) top-level library file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/tier4/awkernel/sessions/2a6ef5c8-5491-440d-bebf-6968b2fa5827 Co-authored-by: nokosaaan <106376734+nokosaaan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/tier4/awkernel/sessions/2a6ef5c8-5491-440d-bebf-6968b2fa5827 Co-authored-by: nokosaaan <106376734+nokosaaan@users.noreply.github.com>
Contributor
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have added the
imu_driverandvehicle_velocity_convertermodules. While I based the test code on the implementation inAutoware, there was no test code forimu_driver, so I created test cases focused on input and output. All test cases have been verified.Related links
https://github.com/autowarefoundation/autoware_core/tree/main/sensing/autoware_vehicle_velocity_converter/test
https://github.com/tier4/tamagawa_imu_driver/tree/ros2
How was this PR tested?
cargo test --manifest-path /path/to/module/Cargo.toml
test_imu_driver.log
test_vehicle_velocity_converter.log
Notes for reviewers