fix(event): correct fork rollback handling in solidity event maps#6718
Open
xxo1shine wants to merge 1 commit intotronprotocol:developfrom
Open
fix(event): correct fork rollback handling in solidity event maps#6718xxo1shine wants to merge 1 commit intotronprotocol:developfrom
xxo1shine wants to merge 1 commit intotronprotocol:developfrom
Conversation
…trigger processing Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
6102162 to
2831e35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix two correctness bugs in event service rollback handling that cause solidity-side event/log triggers to either leak fork- removed entries or be lost during reorg.
When a block is rolled back during fork resolution, its contract triggers are marked
removed=true. The solidity event pipeline depends on this flag plus an in-memory map (Args.getSolidityContractEventTriggerMap/getSolidityContractLogTriggerMap) keyed by block number. Two paths through this pipeline were broken:Removed triggers reached the solidity sink.
ContractTriggerCapsule.processTrigger()only checked
isSolidityEventTriggerEnable / isSolidityLogTriggerEnable, never theremovedflag. Triggers from forked-out blocks were emitted as valid solidity events.Async enqueue raced with reorg cache clearing.
Manager.postContractTriggerposted to a global
triggerCapsuleQueuefor async draining, butreOrgContractTriggerclears the in-memory cache synchronously. Capsules alreadyin the queue could reference state that was about to be invalidated, leading to
either lost events or stale cache reads.
Solidity caches were not cleared on block-process failure or shutdown.
getSolidityContract{Log,Event}TriggerMapentries are populated per block.If
processBlockthrew after population, or on node shutdown, those entriesleaked.
Fixes #6678
Why are these changes required?
This PR has been tested by:
Follow up
Extra details