Implement leveledEnabler for zapcore.nopCore#1514
Open
langbeck wants to merge 1 commit intouber-go:masterfrom
Open
Implement leveledEnabler for zapcore.nopCore#1514langbeck wants to merge 1 commit intouber-go:masterfrom
langbeck wants to merge 1 commit intouber-go:masterfrom
Conversation
|
|
langbeck
force-pushed
the
langbeck/implement-leveledenabler-for-nopcore
branch
from
59fdd09 to
7d1b424
Compare
prashantv
reviewed
Nov 17, 2025
Collaborator
prashantv
left a comment
prashantv
left a comment
There was a problem hiding this comment.
Can you share more details about a scenario where the multiple calls to Enabled has a high performance cost, and is showing up in profiles?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
zapcore.LevelOfis called with azapcore.nopCore{}, it does one type assertion to determine that it doesn't implementleveledEnabler, then it callsEnabled6 times on it before returningInvalidLevel. By implementingleveledEnablerand making it returnInvalidLevel, we can greatly decrease the cost of callingzapcore.LevelOfon nop cores.