Skip to content

feat: add getOwnerName, searchRepositories, getRepositoryName, listBr…#91

Open
jaysomani wants to merge 6 commits intoutopia-php:mainfrom
jaysomani:feat/gitlab-adapter-remaining
Open

feat: add getOwnerName, searchRepositories, getRepositoryName, listBr…#91
jaysomani wants to merge 6 commits intoutopia-php:mainfrom
jaysomani:feat/gitlab-adapter-remaining

Conversation

@jaysomani
Copy link
Copy Markdown
Contributor

…anches, updateCommitStatus, getCommitStatuses

…anches, updateCommitStatus, getCommitStatuses
@jaysomani jaysomani marked this pull request as ready for review April 23, 2026 05:36
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 23, 2026

Greptile Summary

This PR implements six previously-unimplemented GitLab adapter methods: getOwnerName, searchRepositories, getRepositoryName, listBranches, updateCommitStatus, and getCommitStatuses, along with corresponding integration tests. The implementations are generally solid — searchRepositories correctly falls back from group to user namespace, listBranches properly paginates, and error handling follows the patterns established by other methods in the file.

  • P1 — getCommitStatuses missing pagination: unlike listBranches (fixed in this very PR), getCommitStatuses fetches only the first page of results from GitLab's paginated /statuses endpoint, silently dropping entries beyond the default page size for commits with many CI status records.

Confidence Score: 3/5

Not ready to merge — getCommitStatuses silently truncates results for commits with many statuses, an inconsistency that was just fixed for listBranches in the same PR.

One P1 defect remains: getCommitStatuses lacks the pagination loop applied to every other list method in this file. All other issues from previous review threads have been addressed or are intentional design choices per developer response.

src/VCS/Adapter/Git/GitLab.php — specifically the getCommitStatuses method (lines 699–729).

Important Files Changed

Filename Overview
src/VCS/Adapter/Git/GitLab.php Implements six previously-stubbed methods; getCommitStatuses lacks pagination unlike the other list methods in this file, risking silent data truncation for commits with many status entries.
tests/VCS/Adapter/GitLabTest.php Replaces skipped stubs with real integration tests; testSearchRepositoriesWithSearch may be flaky due to GitLab's asynchronous search indexing of newly created repositories.

Reviews (3): Last reviewed commit: "updated with suggesitons 2" | Re-trigger Greptile

Comment thread src/VCS/Adapter/Git/GitLab.php
Comment thread src/VCS/Adapter/Git/GitLab.php
Comment thread src/VCS/Adapter/Git/GitLab.php
Comment thread src/VCS/Adapter/Git/GitLab.php Outdated
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 41a7de28fc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/VCS/Adapter/Git/GitLab.php
Comment thread src/VCS/Adapter/Git/GitLab.php Outdated
Comment thread src/VCS/Adapter/Git/GitLab.php
Comment thread src/VCS/Adapter/Git/GitLab.php
Comment thread src/VCS/Adapter/Git/GitLab.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants