Skip to content

Dev logger topics#310

Open
VLukasBecker wants to merge 28 commits intomainfrom
dev_logger_topics
Open

Dev logger topics#310
VLukasBecker wants to merge 28 commits intomainfrom
dev_logger_topics

Conversation

@VLukasBecker
Copy link
Copy Markdown
Contributor

Subject

Logger extension with additional topic field

Description

Improve the logger with an additional parameter "topic" and a new internal interface. The configuration is adapted accordingly to receive a black- and white list of topics to show or hide in the logs.
The new interface is rolled out in the internal components.

Instructions for review / testing

  • Check the implementation of the configuration (YamlReader.cpp, string_utils.hpp, Configuration.hpp)
  • Check the implementation of the topic handling in the logger (Logger.cpp / IsTopicEnabled() )
  • Check the new "builder-pattern" logger interface implementation (ILoggerInternal.hpp, LoggerMessage.hpp)
  • Skim the usage changes in the numerous components.

Developer checklist (address before review)

  • Changelog.md updated
  • Prepared update for depending repositories
  • Documentation updated (public API changes only)
  • API docstrings updated (public API changes only)
  • Rebase → commit history clean
  • Squash and merge → proper PR title

@VLukasBecker VLukasBecker requested a review from MariusBgm April 16, 2026 14:35
@VDanielEdwards VDanielEdwards self-requested a review April 17, 2026 07:47
Copy link
Copy Markdown
Member

@VDanielEdwards VDanielEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall nice work 👍

Comment thread SilKit/source/config/Configuration.hpp Outdated
Comment thread SilKit/source/config/YamlReader.cpp Outdated
Comment thread SilKit/source/core/internal/traits/SilKitLoggingTraits.hpp Outdated
Comment thread SilKit/source/core/internal/traits/SilKitLoggingTraits.hpp Outdated
Comment thread SilKit/source/core/vasio/io/impl/AsioGenericRawByteStream.cpp Outdated
Comment thread SilKit/source/services/logging/Logger.cpp Outdated
Comment thread SilKit/source/services/logging/Logger.hpp Outdated
Comment thread SilKit/source/services/logging/LoggerMessage.hpp Outdated
Comment thread SilKit/source/services/logging/LoggerMessage.hpp Outdated
Comment thread SilKit/source/services/logging/LoggingSerdes.cpp Outdated
Copy link
Copy Markdown
Member

@VDanielEdwards VDanielEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall nice work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants