Skip to content

Port to Minecraft 26.1.2#21

Merged
vectorwing merged 19 commits intovectorwing:26.1from
Tkain:26.1.1
Apr 22, 2026
Merged

Port to Minecraft 26.1.2#21
vectorwing merged 19 commits intovectorwing:26.1from
Tkain:26.1.1

Conversation

@Tkain
Copy link
Copy Markdown

@Tkain Tkain commented Apr 3, 2026

This PR ports The Block Box to Minecraft 26.1.2.

I started this assuming this was going to be simple. It was not.

Here's a list of the major differences between the mod as it is and this port, most of them technical:

  • Copper bars have been removed since they were introduced to vanilla Minecraft post-1.21.1.
    Copper bars have been renamed to copper lattices to avoid confusion with vanilla's new copper bars.
    • Their block/item IDs, translation keys, and English names have been updated to reflect this. However, their names in other languages have not been changed and will likely need to be addressed by translators.
  • Model datagen has been completely rewritten to account for NeoForge's adoption of vanilla's model generation.
    • I tried to adhere to the mod's current generated models and naming conventions as best as I could, but the limitations of vanilla's model generators mean that some file names have changed (ex. hanging_brazier -> brazier_hanging).
  • NeoForge's SWORD_DIG item ability was removed post-1.21.1, so palisade sharpening now checks whether an item falls under the #minecraft:sword tag instead.
  • The mod's one new damage tag is now datagenned because I ran into datagen errors using it as-is.

All the minor datagen output changes mean this PR changes a lot of files, so I'd recommend reviewing the changes per-commit instead of all at once. I tried to cordon most of the datagen output changes to their own commit and also tried to avoid having multiple commits touch the same file where possible. Let me know if you have any questions or would like to make any changes.

Tkain added 9 commits March 30, 2026 19:17
This commit changes the project's build scripts to target Minecraft 26.1 (instead of 1.21.1). No mod code has been changed, so this won't compile as-is.
This does not include data generation, so the mod still doesn't compile yet. Additionally, there are a few ambiguities I've left as TODOs.
I had to totally rewrite the mod's model data providers since 26.1 NeoForge uses vanilla's model generators instead of its own. I tried to introduce as few changes as possible, but some generated file names have changed due to technical limitations.

As part of this, I also decided to leverage Minecraft's BlockFamily class to eliminate some boilerplate code. This can also be used for recipe generation, but I decided not to mess with more than I already had to.
This includes removing unused resource files and renaming the brazier template to be in line with its post-port naming scheme.
Everything just works this time since 26.1.1 is just a hotfix. Also includes updates to datagen, Gradle, NeoForge, and JEI.
@vectorwing
Copy link
Copy Markdown
Owner

Oh wow! This is quite a surprise to see! 😄

First off, thank you for the sheer effort put into this. Right now I'm working away on a minor release for Farmer's Delight, so my review may take a few days to do, considering it's a version port. I may do it in multiple passes to catch everything. Also, I have yet to read up on all the changes leading up to 26.1, as I was gonna do it during a future FD port, so this might cause my reviews to take longer still.

That said, I will need to make a 26.1 branch for this PR to land on. Assuming you departed from 1.21.1's latest, it should be the same diff. I'll let you know once I do that.

@vectorwing
Copy link
Copy Markdown
Owner

Copper bars have been removed since they were introduced to vanilla Minecraft post-1.21.1.
Is it worth incorporating copper bars' original appearance somehow? Maybe as a built-in resource pack or new item entirely?

I thought about this during the Copper Age announcement, and my plan was to keep my bars under a different name, rather than remove them.

Maybe "Copper Lattice" could work? I could then have freedom to name my custom-appearance bars however I want, and keep "Bars" to the recolored vanilla ones.

@vectorwing vectorwing changed the base branch from 1.21.1 to 26.1 April 3, 2026 05:08
@vectorwing
Copy link
Copy Markdown
Owner

Alright, branch 26.1 created. I pointed the PR to it, and the diff size is the same.

I can get back to this PR in the next few days to review it properly, once I'm done with the other mod. Thanks once again for the port! ^^

@Tkain
Copy link
Copy Markdown
Author

Tkain commented Apr 3, 2026

Not a problem, take as long as you need. Thanks for making your mods in the first place!

Tkain added 2 commits April 15, 2026 21:47
Ditto. This commit also updates a Gradle plugin I forgot to update last commit.
@Tkain Tkain changed the title Port to Minecraft 26.1.1 Port to Minecraft 26.1.2 Apr 18, 2026
@Tkain
Copy link
Copy Markdown
Author

Tkain commented Apr 19, 2026

FYI: I've updated this port to 26.1.2 (no changes needed aside from the version bump) and re-added copper bars as "copper lattices" as you suggested.

@vectorwing
Copy link
Copy Markdown
Owner

Thanks for updating them to Copper Lattice! 👍

Now that FD's 1.3 update is on testing, I can take a proper look at the PR. I'll submit a review if I find anything.

@vectorwing
Copy link
Copy Markdown
Owner

@Tkain Booted the instance locally, and everything seems to be working fine... except for the Braziers.

It seems that their models in 26.1.2 are very misconfigured. But it seems to just be a matter of wrong textures; the templates themselves look the way they should. Some things I noticed:

  • Hanging Braziers are using the standing brazier textures;
  • Lit Braziers are not using the brazier_top_lit texture;
  • Soul Braziers are using the wrong brazier_side_lit texture.

Here are some comparison pictures:

1.21.1

image

26.1.2

image

@Tkain
Copy link
Copy Markdown
Author

Tkain commented Apr 20, 2026

Oops, I should have noticed that. I'm probably just reusing the standing braziers' texture mappings for the hanging ones. I'll fix it as soon as I can.

@Tkain
Copy link
Copy Markdown
Author

Tkain commented Apr 20, 2026

Okay, things should be fixed now:

2026-04-20_16 41 18

@vectorwing
Copy link
Copy Markdown
Owner

vectorwing commented Apr 20, 2026

Looks good! But the interior top textures also have a "lit" texture, with streaks of flame in them.
It should be brazier_top_lit and soul_brazier_top_lit, I think.

image

@Tkain
Copy link
Copy Markdown
Author

Tkain commented Apr 20, 2026

Aw dammit. That should be fixed too now:

2026-04-20_16 47 57

@vectorwing
Copy link
Copy Markdown
Owner

Woo! Thank you! 🙏
I'm going over the code changes currently, and I'll post a review if I find anything else. But so far, so good.

Copy link
Copy Markdown
Owner

@vectorwing vectorwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I finished going over the whole PR. There's only one change I'd like to request here; the other comments are optional observations.

Excellent work overall! Ended up teaching me quite a bit about 26.1, which may help when I port FD to it later.

Comment thread src/main/java/vectorwing/blockbox/common/block/PalisadeBlock.java Outdated
Comment thread src/main/java/vectorwing/blockbox/common/entity/SeatEntity.java Outdated
@Tkain Tkain requested a review from vectorwing April 21, 2026 22:34
@vectorwing
Copy link
Copy Markdown
Owner

Everything looks good now! 👍
Once again, thank you for the work on this port. I'll make sure to credit you on the mod's data, and the release announcement.

@vectorwing vectorwing merged commit f6ce791 into vectorwing:26.1 Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants