Update olcPGEX_Graphics3D.h#236
Open
Spejik wants to merge 1 commit intoOneLoneCoder:masterfrom
Spejik:patch-1
Open
Update olcPGEX_Graphics3D.h#236Spejik wants to merge 1 commit intoOneLoneCoder:masterfrom Spejik:patch-1
Spejik wants to merge 1 commit intoOneLoneCoder:masterfrom
Spejik:patch-1
Conversation
I've been having issues with `m_DepthBuffer` overflowing when Rendering with `RENDER_DEPTH`, so I switched it to `vector<float>` from `float*`, and added a check if the buffer index has overflown. There's possibly some better solutions, however, I didn't see any black pixels appearing in the meshes nor the sky (when Clearing the screen with, let's say, `olc::BLUE`), so I came to the concussion it's fine to do it like this (but correct me if I'm wrong 😄)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been having issues with
m_DepthBufferoverflowing when Rendering withRENDER_DEPTH, so I switched it tovector<float>fromfloat*, and added a check if the buffer index has overflown.There's possibly some better solutions, however, I didn't see any black pixels appearing in the meshes nor the sky (when Clearing the screen with, let's say,
olc::BLUE), so I came to the concussion it's fine to do it like this (but correct me if I'm wrong 😄)