Draft
Conversation
- SqliteVectorStore: only catch "no such table" OperationalError, re-raise others - test_visualizer: fix det.ts → obs.ts, add @pytest.mark.tool, remove double teardown and duplicate assertion - conftest: remove unreachable duplicate return
…ypes - EmbeddingModel/CLIPModel: @overload so single-arg returns Embedding, multi-arg returns list - conftest: cast getfixturevalue returns to correct Store/BlobStore types
- MobileCLIPModel, TorchReIDModel: add matching overloads for embed/embed_text - Remove now-redundant cast in memory/embedding.py
…n guard, strict zip - Delete dimos/memory/type.py (license header only, no code) - Add validate_identifier() to search() and delete() in SqliteVectorStore - Change zip(strict=False) to zip(strict=True) in Batch transformer
# Conflicts: # dimos/memory2/test_visualizer.py # dimos/memory2/transform.py
drawing/Drawing2D becomes space/Space (2D spatial canvas, world frame). graph/GraphTime becomes plot/Plot. Element types split out of the mixed vis/type.py into space/elements.py and plot/elements.py. Color dataclass moves to vis/color.py next to the existing color helpers. Plot itself is a rename only — Series/Markers field names, smart-dispatch, and the hardcoded "time (s)" xlabel are unchanged. Adds plot/rerun.py as a no-op stub so Plot.to_rerun() no longer crashes on import (was a dead import in graph/graph.py). Generalization of Plot beyond time-series is follow-up work. Also: initialize Space._group_seq in __init__ instead of via lazy getattr, drop the Drawing2D backwards-compat alias, and update the three docs callsites under docs/capabilities/memory/ to the new names.
# Conflicts: # dimos/core/module.py # dimos/mapping/voxels.py # dimos/memory2/backend.py # dimos/memory2/module.py # dimos/memory2/notifier/base.py # dimos/memory2/store/memory.py # dimos/memory2/test_e2e.py # dimos/memory2/test_module.py # dimos/memory2/transform.py # dimos/msgs/nav_msgs/OccupancyGrid.py # dimos/msgs/sensor_msgs/PointCloud2.py # dimos/perception/detection/type/detection2d/bbox.py
…patterns - Remove type args from Configurable[T] and Module[T] in memory2 - Replace default_config with config: XConfig annotations - Restore memory2 files from feature branch, PointCloud2 from dev - Fix In import path, bbox applyColorMap type, Go2Recorder start/stop - Remove stale default_config in mujoco_sim_module
- Remove remaining default_config / Configurable[T] in memory2 stores - Fix hex_to_rgb to accept str | Color - Fix word-wrap variable shadowing in rerun renderer - Add missing TYPE_CHECKING imports in elements.py - Fix broken debug print in vis/utils.py - Fix gstreamer type: ignore codes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes DIM-XXX
Solution
Breaking Changes
How to Test
Contributor License Agreement