Skip to content

feat(types): Add Unit enum#1072

Open
szokeasaurusrex wants to merge 1 commit intomasterfrom
szokeasaurusrex/metrics-units
Open

feat(types): Add Unit enum#1072
szokeasaurusrex wants to merge 1 commit intomasterfrom
szokeasaurusrex/metrics-units

Conversation

@szokeasaurusrex
Copy link
Copy Markdown
Member

The Unit enum will be used in the Metric type to store metric units.

Closes #1070
Closes RUST-192

@linear-code
Copy link
Copy Markdown

linear-code Bot commented Apr 21, 2026

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 75ee89b

@szokeasaurusrex szokeasaurusrex marked this pull request as draft April 21, 2026 12:31
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-units branch from 3653ee7 to 9f45f55 Compare April 21, 2026 12:32
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review April 21, 2026 12:32
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-units branch from 9f45f55 to e92d0c8 Compare April 21, 2026 12:34
Copy link
Copy Markdown
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

The `Unit` enum will be used in the `Metric` type to store metric units.

Closes #1070
Closes [RUST-192](https://linear.app/getsentry/issue/RUST-192/add-unit-constantsenum)
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-units branch from e92d0c8 to 75ee89b Compare April 22, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Unit constants/enum

3 participants